Bump bintami common from 1.x -> 2.x to avoid conflicts with other new… #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yreddy-CS
approved these changes
Feb 22, 2024
jp-gouin
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Chart version is already 4.2.2 , you are probably not working on the latest commit here
There was a problem hiding this comment.
Argh must have just missed it did a rebase/push
…er bitnami charts
jgielstra
force-pushed
the
bump-bitnami-common
branch
from
d476c7d
to
670c52b
Compare
|
@jp-gouin, is this PR worth merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er Bitnami charts
What this PR does / why we need it:
I was having conflicts during running
helm installbetween the Bitnami PostgreSQL and OpenLDAP charts due to different versions of the Bitnami Commons scripts 1.x versus 2.x.In my opinion, this is a defect/deficiency with how Helm 3.13.x resolves helper scripts, this seemed to be the simplest fix
Pre-submission checklist: