Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support customSchemaFiles and extraSchemaFiles options #167

Closed
wants to merge 3 commits into from

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jun 4, 2024

What this PR does / why we need it:

The current customSchemaFiles option does a schema import via LDAP_EXTRA_SCHEMAS.
I renamed this current behavior to extraSchemaFiles. It's done via ldapadd while slapd is running.

I added a new customSchemaFiles option that imports schemas via LDAP_CUSTOM_SCHEMA_DIR.
It's done via slapadd while slapd is stopped.

Since the new customSchemaFiles option does not support all schemas that could be set via the current customSchemaFiles option, this change is not backwards compatible. The migration should be easy though because one just needs to use the extraSchemaFiles option instead.

Related issues:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you updated the readme?
  • Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first

@wkloucek wkloucek changed the title use different schema import functionality to guarantuee import order, fixes #104 use different schema import functionality to guarantee import order Jun 4, 2024
@wkloucek wkloucek changed the title use different schema import functionality to guarantee import order support customSchemaFiles and extraSchemaFiles options Jun 13, 2024
@wkloucek
Copy link
Contributor Author

@jp-gouin After digging into this PR, I think we don't really benefit from another schema import besides the one we currently have, especially since the import order was fixed in #161. If you have a reasoning for supporting both mechanisms, I'm happy to continue this PR. Otherwise I'll close it.

@wkloucek wkloucek closed this Jul 15, 2024
@wkloucek wkloucek deleted the fix-104 branch July 15, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import order of customSchemaFiles not deterministic
1 participant