Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAZ-Studio #65

Merged
merged 7 commits into from
Jan 14, 2022
Merged

DAZ-Studio #65

merged 7 commits into from
Jan 14, 2022

Conversation

jp7677
Copy link
Owner

@jp7677 jp7677 commented Jan 5, 2022

No description provided.

src/nvapi_gpu.cpp Outdated Show resolved Hide resolved
The bus slot ID seems to be the same as the PCI device ID.
Assume PCI bus on GPU architecture.
There is no TCC mode on Linux, just return zero GPUs.
@jp7677 jp7677 marked this pull request as ready for review January 14, 2022 08:21
@jp7677
Copy link
Owner Author

jp7677 commented Jan 14, 2022

The method NvAPI_GPU_GetCurrentPCIEDownstreamWidth is also used by DAZ-Studio, but not having this implemented seems not to have any visible effects. We could implement this using NVML (https://docs.nvidia.com/deploy/nvml-api/group__nvmlDeviceQueries.html#group__nvmlDeviceQueries_1g6c1ca57225bd4e6a43916352044340c7), but no need currently.

@SveSop
Copy link
Contributor

SveSop commented Jan 14, 2022

Yeah, i implemented it rather clumsily using nvml in my original nvapi project here:
https://github.com/SveSop/nvapi_standalone/blob/master/dlls/nvapi/nvapi.c#L1040-L1065

But i agree, it does not seem to be needed by DAZ, although i just generally love to have "as many entries as possible" in nvapi, it could be considered unneccesary "bloat" if nothing really fails without the function 😄

This makes this method less depending on NVML. Since the VBIOS revision is just a string, it is very unlikely that this is used for anything other than just presentation.
@jp7677 jp7677 merged commit bcee22e into master Jan 14, 2022
@jp7677 jp7677 deleted the daz-studio branch January 14, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants