Skip to content

Commit

Permalink
obs-ffmpeg: Remove cutoff hack for AAC encoder
Browse files Browse the repository at this point in the history
The cutoff hack was added many, many years ago as recommended by
Konverter.  Since then, there has been much work on the AAC encoder, so
this hack should no longer be necessary.
  • Loading branch information
jp9000 committed Feb 26, 2018
1 parent 26595b5 commit a89470d
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions plugins/obs-ffmpeg/obs-ffmpeg-audio-encoders.c
Expand Up @@ -229,17 +229,7 @@ static void *enc_create(obs_data_t *settings, obs_encoder_t *encoder,
enc->context->sample_rate = closest;
}

/* if using FFmpeg's AAC encoder, at least set a cutoff value
* (recommended by konverter) */
if (strcmp(enc->codec->name, "aac") == 0) {
int cutoff1 = 4000 + (int)enc->context->bit_rate / 8;
int cutoff2 = 12000 + (int)enc->context->bit_rate / 8;
int cutoff3 = enc->context->sample_rate / 2;
int cutoff;

cutoff = MIN(cutoff1, cutoff2);
cutoff = MIN(cutoff, cutoff3);
enc->context->cutoff = cutoff;
}

info("bitrate: %" PRId64 ", channels: %d, channel_layout: %x\n",
Expand Down

0 comments on commit a89470d

Please sign in to comment.