Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed jwt CLI script to jwt-cli to avoid issues with jwt script overlapping with the jwt package. #187

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

mark-adams
Copy link
Contributor

So, instead of getting rid of the jwt CLI script as we discussed in #130, what do you think about just renaming it to jwt-cli so that it doesn't overlap with jwt anymore? That should pretty much fix any outstanding issues.

Thoughts @jpadilla?

@jpadilla
Copy link
Owner

@mark-adams would this be a breaking change? People would be running $ jwt-cli now?

@mark-adams
Copy link
Contributor Author

Great point! Yes, this would be a breaking change. People would run jwt-cli instead of jwt.

I just updated the CHANGELOG to reflect this as well.

@mark-adams
Copy link
Contributor Author

@jpadilla I wanted to clarify one more time before I merged this... are you ok with this rename?

@jpadilla
Copy link
Owner

TBH I don't really like adding cli to it. How about just calling it pyjwt?

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5c5fab1 on fix-cli-script into 0d0d10c on master.

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5c5fab1 on fix-cli-script into 0d0d10c on master.

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5c5fab1 on fix-cli-script into 0d0d10c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5c5fab1 on fix-cli-script into 0d0d10c on master.

@mark-adams
Copy link
Contributor Author

@jpadilla Done! Renamed jwt-cli -> pyjwt

@mark-adams mark-adams merged commit b144666 into master Oct 24, 2016
@mark-adams mark-adams mentioned this pull request Oct 24, 2016
@jpadilla
Copy link
Owner

@mark-adams sweet, thanks! Should we put out a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants