Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 👍 add Japanese language 🇯🇵 #234

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

shin-sforzando
Copy link
Contributor

Dear @jpanther ,

I have added the Japanese language file with reference to the English language file.
However, the words in the English language file are familiar to Japanese people, so I don't feel it is necessary to dare to convert them to Japanese.
If someone uses this Japanese language file, dateFormat in languages.ja.toml should be like "2006年01月02日" to be closer to the Japanese convention.
Anyway, I hope it helps you.

P.S.

Screen Shot 2022-06-29 at 13 00 10

footer:
  dark_appearance: "ダークモードへ切り替え"
  light_appearance: "ライトモードへ切り替え"

Unfortunately, I was unable to complete the verification for the footer appearance switching section.
It keeps showing "Switching to dark" even when switching from dark to light.
Is this happening only in my environment?

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3ddabbb
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/62bbd85224aaab0008a8d7f6
😎 Deploy Preview https://deploy-preview-234--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Issue with i18n translations label Jun 29, 2022
@jpanther
Copy link
Owner

Thanks for the Japanese translation @shin-sforzando! I have often wondered if I should move the dateFormat out of the site config and into the i18n file but I figure most people like to have control over how dates are displayed. I'll merge these changes in and they will be included in the next release.

That issue you are having with the appearance switcher is not just you. It looks like you've found a bug!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 29, 2022
@jpanther jpanther merged commit 9cb8b84 into jpanther:dev Jun 29, 2022
@shin-sforzando
Copy link
Contributor Author

I always appreciate your great themes.
And I love Factorio, too:)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation i18n Issue with i18n translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants