ogt_vox: Merge materials #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the materials of the scenes into the merge scene in ogt_vox_merge_scenes. I added the materials when the color of the master palette is added in previous update_master_palette_from_scene funtion
Remove the const on the cameras of the ogt_vox_scene
This reverts commit cb38f7c.
|
Looks great, thanks for the contribution. Currently palette matching considers only color (see find_exact_color_in_palette and find_closest_color_in_palette), so if you have two palette entries that are both orange but different materials, only one will be transmitted to the final palette. Feel free to take a stab at solving that if you're interested, otherwise no worries, I'll get to it later. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the materials of the scenes into the merge scene in ogt_vox_merge_scenes. I added the materials when the color of the master palette is added in previous update_master_palette_from_scene funtion
#38
PS: this is my first PR 馃檪