feat: emit error instead of logging

[officialpiyush]

Right now, the developers don't have any options ( other than logs ) to know if a post call failed.

Changes

• error event is emitted instead of logging

[officialpiyush]

assuming this follows semantic versioning, I'm updating the package version to 1.2.0

[jpbberry]

I'd prefer that you check for the error event actually being listened to. And if it's not error to console. The package is made for simple users so just completely disregarding all errors if they forget to add the listener seems a bit counter intuitive.

[officialpiyush]

What do you think about adding a config option? That would make more sense tbh. something like logging - enabled by default

[jpbberry]

I'd rather you do

if ('error' in this._events) {
  the.emit('error', ....
} else console.error....

[officialpiyush]

gotcha!

[anishshobithps]

I think it would be better also to include error in this

export interface BasePoster {
	on(event: 'posted', listener: (stats) => void);
	on(event: 'error', listener: (Error) => void);
}

[anishshobithps]

LGTM!

[jpbberry]

This was merged but also accompanied with a breaking importing change in v2.0.0, you can check that here