-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: make typescript a dev dep, bump other deps #6
Conversation
@jpbberry checking previous commits it looks like |
You can delete it. Just FYI, going through a top-gg node-sdk update right now, so I'm going to wait for that before updating this and merging your PR. May take a couple days. Thank you for the PR though! |
i see you released the new @topgg/sdk version some days ago, do i bump it in this PR? if so are there any breaking changes? or are you gonna do it in a separate commit |
@jpbberry i've gone ahead and updated to the latest @top-gg/sdk myself, since it's a patch release i hope it doesn't break anything, also removed express from the devDependencies as only its types are ever used |
@jpbberry hey, it's been a little over 3 months since this PR was made, would you mind taking a look at it? 👀 |
@jpbberry hey, is this planned to get merged anytime soon? i've been relying on my own fork lately that contains this fix and exactly this fix |
Can you bump again and then I'll get this merged and released today |
thanks for replying, do you mean bumping the package.json version or pinging you? |
The package.json, top-gg/sdk had another update, might as well keep up |
done, let me know if you need anything else 🙏 |
currently, a copy of typescript gets installed for everyone that installs this package, this PR changes it so that it doesn't anymore, it's a common practice to have typescript as a dev dependency for this reason
also
updates package-lock.json as it was really outdateddeletes the oldpackage-lock.json