Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: make typescript a dev dep, bump other deps #6

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Mar 16, 2023

currently, a copy of typescript gets installed for everyone that installs this package, this PR changes it so that it doesn't anymore, it's a common practice to have typescript as a dev dependency for this reason

also updates package-lock.json as it was really outdated deletes the old package-lock.json

@SuperchupuDev
Copy link
Contributor Author

@jpbberry checking previous commits it looks like package-lock.json is gitignored, yet it still remained in the repo. should i delete the file instead of updating it?

@jpbberry
Copy link
Owner

You can delete it. Just FYI, going through a top-gg node-sdk update right now, so I'm going to wait for that before updating this and merging your PR. May take a couple days. Thank you for the PR though!

@SuperchupuDev
Copy link
Contributor Author

i see you released the new @topgg/sdk version some days ago, do i bump it in this PR? if so are there any breaking changes? or are you gonna do it in a separate commit

@SuperchupuDev SuperchupuDev changed the title deps: make typescript a dev dependency and bump it deps: make typescript a dev dependency and bump deps Apr 8, 2023
@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Apr 8, 2023

@jpbberry i've gone ahead and updated to the latest @top-gg/sdk myself, since it's a patch release i hope it doesn't break anything, also removed express from the devDependencies as only its types are ever used

@SuperchupuDev SuperchupuDev changed the title deps: make typescript a dev dependency and bump deps deps: make typescript a dev dep, bump other deps Apr 8, 2023
@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Jul 2, 2023

@jpbberry hey, it's been a little over 3 months since this PR was made, would you mind taking a look at it? 👀

@SuperchupuDev
Copy link
Contributor Author

@jpbberry hey, is this planned to get merged anytime soon? i've been relying on my own fork lately that contains this fix and exactly this fix

@jpbberry
Copy link
Owner

jpbberry commented Feb 4, 2024

Can you bump again and then I'll get this merged and released today

@SuperchupuDev
Copy link
Contributor Author

thanks for replying, do you mean bumping the package.json version or pinging you?

@jpbberry
Copy link
Owner

jpbberry commented Feb 4, 2024

The package.json, top-gg/sdk had another update, might as well keep up

@SuperchupuDev
Copy link
Contributor Author

done, let me know if you need anything else 🙏

@jpbberry jpbberry merged commit 7b5fc29 into jpbberry:master Feb 4, 2024
@SuperchupuDev SuperchupuDev deleted the master branch February 4, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants