Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a bit of code cleanup #111

Merged
merged 3 commits into from
Feb 24, 2023
Merged

a bit of code cleanup #111

merged 3 commits into from
Feb 24, 2023

Conversation

zed-0xff
Copy link
Contributor

  1. remove unused variables
  2. all CMYK fixtures are actually RGBA
  3. add rgb.jpg test with correct fixture

Tests: 28 passed, 28 total

patrickhulce
patrickhulce approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zed-0xff :)

@patrickhulce patrickhulce merged commit b8cfcd4 into jpeg-js:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zed-0xff @patrickhulce