Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jenkins plugin downloader #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PierreSchwang
Copy link

@PierreSchwang PierreSchwang commented Sep 27, 2023

Adds a kinda-easy & standardized way to download Jenkins artifacts instead of doing all the rest calls and delegating to url() in the projects itself.

Haven't used Kotlin that much (as most likely visible) - so open for review and modifications ^^

(Ignore the branch name...)

@jpenilla
Copy link
Owner

The API requests should be cached similarly to how the Modrinth metadata is. The other thing is the cache doesn't handle changing versions currently. We should add some sort of marker and have a configuration for how often to refresh them.

@PierreSchwang
Copy link
Author

The API requests should be cached similarly to how the Modrinth metadata is. The other thing is the cache doesn't handle changing versions currently. We should add some sort of marker and have a configuration for how often to refresh them.

I don't think Jenkins provides any kind of E-Tag header or anything remotely similar nor useful there. I just downloaded the remote jar and didn't care about potential duplicated builds as that should never happen either way (as it's incrementing and therefor kinda cache-controlled).

The only thing that could be cached would be the latest build-number - but that would either require an appropriate response header (which feels way over the top as the response body is literally a few bytes) or some kind of duration for cache hits (which might impact UX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants