Model cast count as integer

[daniel-aranda]

Not a big deal, but as I was writing some unit tests I figured this small glitch.

Test:

  $this->assertSame(3, App\Models\SomeModel::count());

Result:

Failed asserting that '3' is identical to 3.

[koenpunt]

Thanks, can you squash your commits?

[Rican7]

Yea, a quick squash and this would be good to merge. Thanks for this!

[koenpunt]

And, is it necessary to assign it to the $count variable before returning?

[daniel-aranda]

Squash done at 8bfb68b.

I added the var because I like to separate tasks(thinking in readability), one task is to count a resultset and other to cast the result.

For readability is harder to understand a line with more than one task. For this particular case, this is not a biggie so I removed it.

Thanks for the review guys, please let me know any other issue.

Bests,

[koenpunt]

Cool, thanks!

[Rican7]

Thanks for the contribution and quick action! 👍