Skip to content

Commit

Permalink
Merge pull request #116 from jpgill86/neo-0.8.0
Browse files Browse the repository at this point in the history
Add Travis CI workaround for elephant's incompatibility with Neo 0.8.0
  • Loading branch information
jpgill86 committed Oct 9, 2019
2 parents 41cd0dc + fb8166c commit f1fa360
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ install:

# install package
- echo "INSTALLING NEUROTIC"
- python setup.py install
# - python setup.py install

# temporary, very dirty workaround for elephant incompatibility with neo 0.8 -- REMOVE LATER
- pip install --no-warn-conflicts . # will write version.py to a temp dir, so manually create it below
- echo version=\'unknown\' > neurotic/version.py
- echo git_revision=\'unknown\' >> neurotic/version.py

before_script:
# list versions
Expand Down
4 changes: 2 additions & 2 deletions neurotic/datasets/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def _read_data_file(metadata, lazy=False, signal_group_mode='split-all'):
# load all objects except analog signals
if lazy:

if version.parse(neo.__version__) >= version.parse('0.8.0.dev'): # Neo >= 0.8.0 has proxy objects with load method
if version.parse(neo.__version__) >= version.parse('0.8.0'): # Neo >= 0.8.0 has proxy objects with load method

for i in range(len(blk.segments[0].epochs)):
epoch = blk.segments[0].epochs[i]
Expand Down Expand Up @@ -407,7 +407,7 @@ def _create_neo_spike_trains_from_dataframe(dataframe, metadata, t_start, t_stop

def _apply_filters(metadata, blk):
"""
Apply filters specified in ``metadata`` the the signals in ``blk`` using
Apply filters specified in ``metadata`` to the signals in ``blk`` using
:func:`elephant.signal_processing.butter`.
"""

Expand Down

0 comments on commit f1fa360

Please sign in to comment.