Port to http 1.0 and tower-http 0.5 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah here is a graceful shutdown example https://github.com/hyperium/hyper/blob/master/examples/graceful_shutdown.rs. I'll incorporate that here. |
|
Thanks, it seems to work fine even without graceful shutdown! I believe I added that because Ctrl+C used to not work without it (when browser tab still open, due to keepalive or whatever). The way to run it is just |
jplatte
approved these changes
Nov 21, 2023
Not exactly needed for this use case. Ctrl+C cancels reliably, which is all that matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to run it but at least it compiles.