Skip to content

Commit

Permalink
Fix windows installer
Browse files Browse the repository at this point in the history
The windows installer would not launch on some systems. Updated readme
to not take any shortcuts in trying to make the install size smaller...
  • Loading branch information
jplsek committed Mar 4, 2019
1 parent bd7aaeb commit 930603d
Show file tree
Hide file tree
Showing 10 changed files with 17 additions and 104 deletions.
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2016, Jeremy Plsek
Copyright (c) 2019, Jeremy Plsek
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down
2 changes: 1 addition & 1 deletion win-installer/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
*.exe
puush-qt/packages/puushqt/data
puush-qt/packages/root/data
18 changes: 5 additions & 13 deletions win-installer/README.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
From Qt's maintenance tools, install the Qt Installer Framework.
From its bin folder, copy `binarycreator.exe` and `installerbase.exe` to this folder.

Create a release executlable of puush-qt.
Create a release executable of puush-qt.
Create the folder `puush-qt/packages/puushqt/data`.
Copy the executlable and dll to `puush-qt/packages/puushqt/data`.
Copy the executable and dll to `puush-qt/packages/puushqt/data`.

I have no idea if there is an automatic way to detect qml application shared libraries, so this is how to manually set up the data directory.
Run `windeployqt.exe` with --qmldir option set and pointing to the executable you copied.

Go to Qt's bin folder, and copy all the dll's to the same folder.
From the Qt's qml folder, copy Qt, QtQuick, and QtQuick.2 to the same folder.
Delete all .qml files (keeping the .qmlc files).
`puush-qt.exe` should now start.
While it's running, make sure the settings window works.
Assuming it works (and while it's still running), try to delete ALL dll's (including subdirectories) in the folder EXCEPT d3d, libEGL, and libGLESv2 (graphical fallback libraries). Windows will not allow you to delete the dll's that are in use.
Now the hard part.
To make the installer have less bloat, look through each subdirectory, and delete folders and qml files that are not needed. To check if they are not needed, restart `puush-qt.exe` and see if the settings window still works. Check the previous installers to see what may be necessary and removed.
Double check the running puush-qt from within the data directory works (and double check the qml loads when checking the puush-qt's settings window).


Finally, once the data folder looks good, update the version and release information in the config and meta folders.
Update the version and release information in the config and meta folders.

Run `build.bat` to create the `puush-qt-installer.exe`.
7 changes: 6 additions & 1 deletion win-installer/puush-qt/config/config.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<Installer>
<Name>puush-qt</Name>
<Version>0.2</Version>
<Version>0.2.4</Version>
<Title>puush-qt Installer</Title>
<Publisher>puush-qt</Publisher>
<ProductUrl>https://github.com/jplsek/puush-qt</ProductUrl>
<InstallerApplicationIcon>puush-qt.png</InstallerApplicationIcon>
<InstallerWindowIcon>puush-qt.png</InstallerWindowIcon>
<Logo>puush-qt.png</Logo>
<RunProgram>@TargetDir@/puush-qt.exe</RunProgram>
<StartMenuDir>puush-qt</StartMenuDir>
<TargetDir>@ApplicationsDir@/puush-qt</TargetDir>
</Installer>
36 changes: 0 additions & 36 deletions win-installer/puush-qt/packages/puushqt/meta/finishform.ui

This file was deleted.

44 changes: 0 additions & 44 deletions win-installer/puush-qt/packages/puushqt/meta/installscript.qs

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2016, Jeremy Plsek
Copyright (c) 2019, Jeremy Plsek
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<Package>
<DisplayName>puush-qt application</DisplayName>
<Description>The puush-qt executable.</Description>
<Version>0.1</Version>
<ReleaseDate>2017-04-28</ReleaseDate>
<Description>A GUI frontend for puush on Windows. This will create a system tray icon and contains similar options to the original puush application before moving to ShareX.</Description>
<Version>0.2.4</Version>
<ReleaseDate>2019-03-03</ReleaseDate>
<ProductUrl>https://github.com/jplsek/puush-qt</ProductUrl>
<Licenses>
<License name="BSD Clause 3 License Agreement" file="license.txt" />
</Licenses>
<Script>installscript.qs</Script>
<UserInterfaces>
<UserInterface>finishform.ui</UserInterface>
</UserInterfaces>
<ForcedInstallation>true</ForcedInstallation>
</Package>

0 comments on commit 930603d

Please sign in to comment.