Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interceptor regexp ignores domains with dashes and without www subdomain #20

Closed
kendrikat opened this issue Apr 6, 2014 · 2 comments
Closed

Interceptor regexp ignores domains with dashes and without www subdomain #20

kendrikat opened this issue Apr 6, 2014 · 2 comments

Comments

@kendrikat
Copy link

Hi,

http://regex101.com/r/cR5tR1

this shows, that https://test-site.com does not match, but https://www.test-site.com does.
@jpmcgrath
Copy link
Owner

I believe that this was fixed in #34 and is now in the latest version of the gem v0.5.3.

@jpmcgrath
Copy link
Owner

p.s. thanks for raising this issue, and apologies for letting this issue languish for so long.

jpmcgrath pushed a commit that referenced this issue Sep 20, 2015
spec for url that does not start with www, and has dash
f43ff01 
As mentioned in #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmcgrath @kendrikat