add tests for local and smb flavors of PyFilesystemContentsManager #16
Conversation
- acheived by deleting files in a bucket from leaf to roots. Turns out it's ridiculously expensive (at least with s3proxy) to delete a non-empty s3 dir
- by default, netbiosd is always running on osx. This blocks the netbios name port (137/udp) and most of the functionality of the nmbd netbios demon that run on the samba docker. Work around netbiosd by using a different name_port for our samba-related activities
telamonian
force-pushed
the
smb_local_ci_tests
branch
2 times, most recently
from
8b0fddb
to
3ca2184
Compare
telamonian
force-pushed
the
smb_local_ci_tests
branch
from
3ca2184
to
865f4e5
Compare
|
I got the samba flavor of Presumably it will work on Windows as well. It'll be a bit tricky, though. On OSX/Linux I set up a docker that exposes a samba service during the CI. This isn't really an option on Windows, and probably isn't what we want anyway. Instead, it would make a much better test if we can get What makes this difficult is that I don't currently have a Windows dev environment set up, so I can't test anything locally. What I'll have to figure out is how to set up a Windows share folder from scratch using only the command line (ie what's available to me on the standard Azure Windows host). @timkpaine Any ideas? |
- creates a new 'smbuser' user and gives them rights to a new 'test' share at c:\shared - the stop script undoes the above
telamonian
force-pushed
the
smb_local_ci_tests
branch
from
9f15dd1
to
a6dc353
Compare
telamonian
force-pushed
the
smb_local_ci_tests
branch
from
97f1778
to
6117ab9
Compare
telamonian
force-pushed
the
smb_local_ci_tests
branch
4 times, most recently
from
eba9a76
to
80c3eaf
Compare
telamonian
force-pushed
the
smb_local_ci_tests
branch
2 times, most recently
from
0db98eb
to
3d01a94
Compare
telamonian
force-pushed
the
smb_local_ci_tests
branch
from
3d01a94
to
ab6ad2a
Compare
telamonian
force-pushed
the
smb_local_ci_tests
branch
from
ab6ad2a
to
f3079d5
Compare
|
Whelp, the Azure Windows build is still borked, but there's now a complete working example of jupyter-fs + samba on Windows over at Appveyor: https://ci.appveyor.com/project/telamonian/jupyter-fs/builds/32177461 |
- also enabled linting and js tests in appveyor
|
@timkpaine I've done all that I planned for this PR and all of the tests are now passing, including the windows ci on appveyor: https://ci.appveyor.com/project/telamonian/jupyter-fs/builds/32184243 For now, the windows ci on azure has been disabled. This PR is now ready for review! |
|
Merge at will! |
|
Turns out I can't merge: FML The tests are passing, but Github is being janky and the statuses aren't collecting correctly. @timkpaine Do you have enough access to override and merge? |
|
@telamonian I didn't merge I just tried to get it to retrigger the checks |
|
@timkpaine I know. I was trying to see if I left it closed for an hour and then reopened if that would make any difference with the statuses bug. But it probably wasn't going to anyway |
|
@telamonian lol |
telamonian
changed the title
|
@telamonian looks like it worked after merge |
currently just has tests for the local flavor