Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "jlab3 and restore to working form" #93

Closed
wants to merge 7 commits into from
Closed

Conversation

telamonian
Copy link
Collaborator

Reverts #85. #85 was originally pulled in without discussion or review, which it very much requires. #85 is at least 2 separate PRs:

  • the jlab3 upgrade
  • a whole bunch of code style and dev env tweaks

Problems:

  • jlab3 and restore to working form #85 was not discussed or reviewed
  • mixing major code autoformat tweaks and the jlab3 upgrade is a Bad Idea. Aside from totally obfuscating the upgrade code, this approach guarantees that any backports will be as painful to create as humanly possible
  • we already have perfectly acceptable python autoformatting. I do not want black
  • the top-level package.json should remain where it is

@timkpaine
Copy link
Collaborator

discussed offline, moving into #97 for changes

@timkpaine timkpaine closed this Mar 31, 2021
@timkpaine timkpaine deleted the revert-85-jlab3 branch June 12, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants