Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert black #97

Merged
merged 8 commits into from
Mar 31, 2021
Merged

revert black #97

merged 8 commits into from
Mar 31, 2021

Conversation

timkpaine
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@telamonian telamonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I'll find something else caused by #85 to be angry about later, but so far as I can see this PR has everything that I needed now.

so, LGTM!

assuming the CI passes

…hat too

- why tsconfig.eslint.json is required. It's so that you can both have support for type-based rules via parserOptions.project in .eslintrc.js, and also have a tsconfig that includes the srcs in tests/. Without that you get an error
@telamonian telamonian merged commit 1f9f659 into main Mar 31, 2021
@timkpaine timkpaine deleted the linting branch June 12, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants