Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a Mosaic plugin to set lab status on component pages #2564

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Use a Mosaic plugin to set lab status on component pages #2564

merged 5 commits into from
Oct 30, 2023

Conversation

DavieReid
Copy link
Contributor

@DavieReid DavieReid commented Oct 6, 2023 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5fb6ceb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 5:43pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Storybook Preview Link https://9ce93202.saltdesignsystem-storybook.pages.dev

JoanaMMoreira
JoanaMMoreira previously approved these changes Oct 9, 2023
View reviewed changes
JoanaMMoreira
JoanaMMoreira reviewed Oct 9, 2023
View reviewed changes
site/mosaic.config.js Outdated Show resolved Hide resolved
site/mosaic.config.js Show resolved Hide resolved
@JoanaMMoreira JoanaMMoreira self-requested a review October 9, 2023 08:37
joshwooding
joshwooding reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I entirely understand the approach here. It seems strange that we've gone from the mdx being the source of truth for the component status to a list in a config?

@DavieReid
Copy link
Contributor Author

I'm not sure if I entirely understand the approach here. It seems strange that we've gone from the mdx being the source of truth for the component status to a list in a config?

Uses the page metadata now. list of labs components has been removed

joshwooding
joshwooding previously approved these changes Oct 30, 2023
View reviewed changes
@joshwooding joshwooding changed the title 2503 mosaic plugin Use a Mosaic plugin to set lab status on component pages Oct 30, 2023
@mark-tate mark-tate self-requested a review October 30, 2023 17:12
@joshwooding joshwooding merged commit 6d02c5f into main Oct 30, 2023
15 checks passed
@joshwooding joshwooding deleted the 2503-mosaic-plugin branch October 30, 2023 17:53
@origami-z origami-z mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate approved these changes

@joshwooding joshwooding joshwooding approved these changes

@JoanaMMoreira JoanaMMoreira Awaiting requested review from JoanaMMoreira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavieReid @mark-tate @joshwooding @JoanaMMoreira