-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bordered
prop to DatePicker and DateInput
#3798
Add bordered
prop to DatePicker and DateInput
#3798
Conversation
🦋 Changeset detectedLatest commit: e126604 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
88c863f
to
260dbd3
Compare
bordered
prop to DatePicker and DateInput
Can we add a 1px gap between the input and the menu? Should the month and year drop-downs also be bordered in this example @bhoppers2008 @pseys @joshwooding? |
Personally I don't think it's necessary, but I'll bow to Darrin's superior judgement. |
If this is my decision, my assumption is if a designer is choosing to use borders on the date input itself, they would want the same style for similar controls throughout the UI. That said, if borders are turned on for the input, they should also turn on for the drop-downs in this component. Unless people have a strong opinion otherwise. See @joshwooding screen shots above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dplsek has asked for the dropdowns to be bordered in the calendar when DatePicker is bordered
6e342aa
to
20e5fb3
Compare
20e5fb3
to
01830d4
Compare
added Labs API note to changeset and pointed reader to the DatePicker PR
9d0b28d
to
e126604
Compare
No description provided.