Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bordered prop to DatePicker and DateInput #3798

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Add bordered prop to DatePicker and DateInput #3798

merged 8 commits into from
Aug 6, 2024

Conversation

ThusharaJ07
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e126604

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/lab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024

@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@ThusharaJ07 ThusharaJ07 mentioned this pull request Jul 11, 2024
Closed
1 task
@joshwooding joshwooding marked this pull request as draft July 11, 2024 07:21
@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:10pm

@joshwooding joshwooding force-pushed the bordered-datepicker branch 2 times, most recently from 88c863f to 260dbd3 Compare July 16, 2024 09:45
@joshwooding joshwooding changed the title bordered DateInput Add bordered prop to DatePicker and DateInput Jul 16, 2024
@origami-z origami-z marked this pull request as ready for review July 19, 2024 09:15
@dplsek
Copy link

dplsek commented Jul 22, 2024

Can we add a 1px gap between the input and the menu?

Should the month and year drop-downs also be bordered in this example @bhoppers2008 @pseys @joshwooding?

@pseys
Copy link
Contributor

pseys commented Jul 23, 2024

Should the month and year drop-downs also be bordered in this example @bhoppers2008 @pseys @joshwooding?

Personally I don't think it's necessary, but I'll bow to Darrin's superior judgement.

@joshwooding
Copy link
Contributor

joshwooding commented Jul 23, 2024 •
edited
Loading

image
image
image

@dplsek
Copy link

dplsek commented Jul 23, 2024 •
edited
Loading

If this is my decision, my assumption is if a designer is choosing to use borders on the date input itself, they would want the same style for similar controls throughout the UI. That said, if borders are turned on for the input, they should also turn on for the drop-downs in this component. Unless people have a strong opinion otherwise.

See @joshwooding screen shots above

joshwooding
joshwooding previously requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dplsek has asked for the dropdowns to be bordered in the calendar when DatePicker is bordered

joshwooding
joshwooding previously approved these changes Aug 5, 2024
View reviewed changes
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Aug 5, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Aug 5, 2024
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Aug 6, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Aug 6, 2024
@joshwooding joshwooding merged commit 888406d into jpmorganchase:main Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate approved these changes

@joshwooding joshwooding joshwooding approved these changes

@bhoppers2008 bhoppers2008 Awaiting requested review from bhoppers2008

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ThusharaJ07 @dplsek @pseys @joshwooding @mark-tate