Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shallow comparison should compare items not arrays #38

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix: shallow comparison should compare items not arrays #38

merged 1 commit into from
Nov 28, 2022

Conversation

lmammino
Copy link
Contributor

I have a feeling that there was some mistake in the shallowIsEqual function. It seems to compare a and b n times rather than comparing every single item in a and b...

This PR suggests a fix

@netlify
Copy link

netlify bot commented Nov 27, 2022 •
edited

❌ Deploy Preview for eleventy-plugin-related failed.

Name Link
🔨 Latest commit 049c889
🔍 Latest deploy log https://app.netlify.com/sites/eleventy-plugin-related/deploys/6383b5447294bf0008d8298a

@jpoehnelt jpoehnelt merged commit 2730dbf into jpoehnelt:main Nov 28, 2022
github-actions bot pushed a commit that referenced this pull request Nov 28, 2022
@jpoehnelt
fix: shallow comparison should compare items not arrays (#38) 2730dbf
a65458e
github-actions bot pushed a commit that referenced this pull request Nov 28, 2022
@semantic-release-bot
chore(release): 1.0.6 [skip ci]
f8fa2cb 
### [1.0.6](v1.0.5...v1.0.6) (2022-11-28)

### Bug Fixes

* shallow comparison should compare items not arrays ([#38](#38)) ([2730dbf](2730dbf))

### Miscellaneous Chores

* **deps:** bump engine.io from 6.2.0 to 6.2.1 ([#37](#37)) ([e16e764](e16e764))
@github-actions
Copy link

🎉 This PR is included in version 1.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lmammino lmammino deleted the patch-1 branch November 28, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpoehnelt jpoehnelt jpoehnelt approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmammino @jpoehnelt