Enable PKI (RSA) cryptosystem in SMAdaptor #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7c3e9f has introduced method translateKeySchemeImpl with wrong scope
In order to ensure the possibility of using other keys than a variant, was needed reorganization of existing structures SecureKey and SecureDESKey. * Introduced new class SecureVariantKey with variant attributes. * Variant attributes was moved form SecureDESkey to this new as more relevant. * Schema attributes as general for all kinds of keys was moved to SecureKey This commit introduce separation between variant keys and possible in future other kinds (e.g. TR-31 key block keys or equivalent). It enables also additional extending of variant keys for example private or public keys (which do not have a key check value).
ar
added a commit
that referenced
this pull request
Jan 5, 2016
Enable PKI (RSA) cryptosystem in SMAdaptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are in 03d5397 where structure of SecureKey and SecureDESKey was refactored (with care about backward compatibility) These changes are important because of the upcoming PCI requirements (for TR-31 or equivalent, see https://www.pcisecuritystandards.org/documents/PTS_PIN_Technical_FAQs_v2_Nov_2015_final.pdf section PIN Security Requirement 18)
46d5453 - provide interface for data signature calculation (encription with private key), but this is useless when there is no private key. So 77eac37 provide interface for key pair generation.
Algorithm for calculating the signature data is easy to implement.
But I can not reveal the private key encryption (emulated HSM), even knowing the proper key pair and a variant of LMK. Therefore, at the moment it is possible to implement only the generation of the private key that will work with JCESecurityModule but will not be accepted by the emulated HSM (like a PIN under LMK)