-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve assign peptide type 243 #263
base: developer
Are you sure you want to change the base?
Conversation
Let me know if I should review this. |
…jpquast/protti into improve_assign_peptide_type_243
…jpquast/protti into improve_assign_peptide_type_243
…jpquast/protti into improve_assign_peptide_type_243
@jpquast i'm getting an error from vroom on macos and windows- have you seen this error before? (it's not related to the changes i made) |
Hi Elena, As far as I can tell the output of the function is generally currently wrong:
Row 2 should be semi-tryptic since the aa_before is not K/R. Not sure why the function now gets those standard cases wrong. Not sure why vroom fails, but if it still does we can have a look at that. |
closes #243