Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry guys! Turns out
electron-compile
doesn't actually useelectron
underneath, it just depends onelectron-prebuilt-compile
, so we can'tresolve('electron-compile')
. So #111 won't work if the user haselectron-compile
as a dependency.Since
electron-compile
depends on its prebuilt counterpart, we can justresolve
that and it will work in both cases (whether they haveelectron-compile
or justelectron-prebuilt-compile
).