Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for electron-compile support #112

Merged
merged 1 commit into from Sep 2, 2017
Merged

fix for electron-compile support #112

merged 1 commit into from Sep 2, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2017

Sorry guys! Turns out electron-compile doesn't actually use electron underneath, it just depends on electron-prebuilt-compile, so we can't resolve('electron-compile'). So #111 won't work if the user has electron-compile as a dependency.

Since electron-compile depends on its prebuilt counterpart, we can just resolve that and it will work in both cases (whether they have electron-compile or just electron-prebuilt-compile).

@ghost
Copy link
Author

ghost commented Sep 1, 2017

Not entirely sure why that build failed in Travis, doesn't look like it has anything to do with the module though...

@inukshuk inukshuk merged commit 25d61cf into jprichardson:master Sep 2, 2017
@inukshuk
Copy link
Collaborator

inukshuk commented Sep 2, 2017

Thanks for the follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant