-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy
does not preserve file ownership and permissons
#54
Comments
Thanks, I will take a look at this on Tuesday or Wednesday. |
I'm wondering if it may be an issue with the module |
Hi there. Nonetheless I came up with a tentative fix. I'll try to write a pull request as well as a test as soon as possible. |
Oops. I forked it and applied my changes, but it fails the test |
Yeah, |
Any idea why that test is failing? I couldn't understand why my changes triggered an issue with filters. |
@NicolaOrritos It's not clear to me what issue you're having. The test passes fine. If your issue is different than this one, please open a new issue with a detailed instructions on how to reproduce the error that you're receiving. Thank you. |
One step closer: 082aa7f Preserving modes is fixed. |
@jprichardson I gave my best to get an understanding of what happens during the copy-job but phew.. if (initialPathIsDirectory) {
results.push(catchAndShowFileErrors((function(_this) {
return function() {
fs.copySync(initialPath, newPath);
return _this.emitter.emit('entry-copied', {
initialPath: initialPath,
newPath: newPath
});
};
})(this))); from They seem to use the fs.copySync function which should preserve the permissions as per the changelogs of node-fs-extra:
Atom makers and I would be thankful for any help! |
Bumps [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) from 7.0.2 to 8.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.
The text was updated successfully, but these errors were encountered: