Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensureLink does not ensure the destination is hard linked to the source #870

Closed
pyrocat101 opened this issue Feb 24, 2021 · 1 comment
Closed
Labels
Milestone

Comments

@pyrocat101
Copy link

@pyrocat101 pyrocat101 commented Feb 24, 2021

  • Operating System: macOS 10.15.7
  • Node.js version: v12.20.1
  • fs-extra version: 5.0.0 (checked source code in master and the issue is still there)

ensureLink shortcuts if the destination path exists, without verifying if the destination file's inode is the same as the source file. This is misleading because it is not really an "ensurance".

Relevant code:

if (destinationExists) return callback(null)

@RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Feb 25, 2021

I think this should be fixed by #826; would appreciate review/testing there.

@RyanZim RyanZim added the bug label Apr 1, 2021
@RyanZim RyanZim added this to the 10.0.0 milestone Apr 1, 2021
RyanZim added a commit that referenced this issue Apr 1, 2021
@RyanZim RyanZim closed this in #826 Apr 2, 2021
RyanZim added a commit that referenced this issue Apr 2, 2021
…ink (#826)

Fixes #786
Fixes #870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants