Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createOutputStream #118

Merged
merged 1 commit into from
Mar 27, 2015
Merged

createOutputStream #118

merged 1 commit into from
Mar 27, 2015

Conversation

charlierudolph
Copy link
Contributor

fs.createWriteStream but makes the parent directories if needed.

Happy to change the name if anyone has a better idea.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.81%) to 82.79% when pulling 2dbee57 on charlierudolph:cr-createWriteStreamP into c062045 on jprichardson:master.

@jprichardson
Copy link
Owner

Awesome. To follow existing conventions of outputJson and outputFile, I think it'd be best to name it outputWriteStream.

@jprichardson
Copy link
Owner

Note, I'm willing to rename the entire prefix output of the three methods to something else if someone can think of something better.

@charlierudolph charlierudolph changed the title getWriteStream createOutputStream Mar 15, 2015
@charlierudolph
Copy link
Contributor Author

@jprichardson updated

Since "output" is replacing "write" in those names I went ahead and renamed this to createOutputStream.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.81%) to 82.79% when pulling af6402c on charlierudolph:cr-createWriteStreamP into c062045 on jprichardson:master.

@charlierudolph
Copy link
Contributor Author

@jprichardson bump

jprichardson added a commit that referenced this pull request Mar 27, 2015
@jprichardson jprichardson merged commit 3d9c5ae into jprichardson:master Mar 27, 2015
@jprichardson
Copy link
Owner

Thanks for your patience on this. I'm not keen on the output substitution that I chose for the methods that create a directory if it doesn't exist... I just haven't been able to think of anything better. But if you come up with something better, please let me know! I should be able to publish this within the next day or so. Feel free to ping me if that doesn't happen :)

@jprichardson
Copy link
Owner

Published: https://github.com/jprichardson/node-fs-extra/releases/tag/0.17.0 I changed it though. I think you'll like the new change, take a look and let me know.

@jprichardson
Copy link
Owner

Thanks for your contribution and help!

@charlierudolph
Copy link
Contributor Author

Awesome. Thanks

@charlierudolph charlierudolph deleted the cr-createWriteStreamP branch March 28, 2015 15:59
@bobtherobot
Copy link

Here are some alternatives for the term "output"

  • undertake
  • stab
  • engage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants