Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fs.realpath.native in envs that support it #682

Merged
merged 5 commits into from May 14, 2019

Conversation

@RyanZim
Copy link
Collaborator

RyanZim commented May 13, 2019

Closes #650

@RyanZim RyanZim requested review from JPeer264 and manidlou May 13, 2019
RyanZim added 2 commits May 13, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 13, 2019

Coverage Status

Coverage decreased (-0.07%) to 83.835% when pulling 8893617 on realpath.native into 32a65ff on master.

@manidlou

This comment has been minimized.

Copy link
Collaborator

manidlou commented May 13, 2019

good! so we don't need to do anything for fs.realpathSync.native?

@RyanZim

This comment has been minimized.

Copy link
Collaborator Author

RyanZim commented May 13, 2019

I think that should work without anything special, since we don't have promises in the mix, but it wouldn't hurt to add a test.

@RyanZim RyanZim merged commit fa661f3 into master May 14, 2019
4 of 5 checks passed
4 of 5 checks passed
coverage/coveralls Coverage decreased (-0.07%) to 83.835%
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@RyanZim RyanZim deleted the realpath.native branch May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.