Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

国税庁HPリニューアルに伴いリンクを修正 #37

Merged
merged 2 commits into from
Apr 1, 2018

Conversation

mugi-uno
Copy link
Contributor

@mugi-uno mugi-uno commented Apr 1, 2018

国税庁HPリニューアルに伴い、
READMEやソースコードのコメント記述のリンクが不正となっていたので、
新しいURLに変更しました。

fix #36

Copy link
Contributor

@corocn corocn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO AHEAD

@@ -5,7 +5,7 @@
`gensen` は日本の源泉徴収税計算用のライブラリです。

## 説明
[国税庁の資料](https://www.nta.go.jp/shiraberu/ippanjoho/pamph/gensen/shikata2017/01.htm)を元にした実装になっています。
[国税庁の資料](https://www.nta.go.jp/publication/pamph/gensen/shikata2017/01.htm)を元にした実装になっています。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018年に .htm を見るとは思わなかったわ

@@ -1,7 +1,7 @@
import BN from "bignumber.js";

// P21 13 馬主に支払う競馬の賞金
// http://www.nta.go.jp/shiraberu/ippanjoho/pamph/gensen/shikata2017/pdf/09.pdf
// https://www.nta.go.jp/publication/pamph/gensen/shikata2017/pdf/09.pdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

Copy link
Contributor

@renyamizuno renyamizuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good K◯LL

LGTM

@renyamizuno renyamizuno merged commit ba8e496 into master Apr 1, 2018
@renyamizuno renyamizuno deleted the fix_link branch April 1, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

国税庁ホームページリニューアルによるリンク切れ
3 participants