Sequence is in collections.abc in Python 3.3+

jpype-project · Jan 23, 2020 · a3912e7 · a3912e7
1 parent 06dec7a
commit a3912e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/jpype/_jarray.py b/jpype/_jarray.py
@@ -247,7 +247,7 @@ def _JArrayNewClass(cls, ndims=1):
 
 # FIXME JavaArrayClass likely should be exposed for isinstance, issubtype
 # FIXME are these not sequences?  They act like sequences but are they
-# connected to collections.Sequence
+# connected to collections.abc.Sequence
 # has: __len__, __iter__, __getitem__
 # missing: __contains__ (required for in)
 # Cannot be Mutable because java arrays are fixed in length

diff --git a/test/jpypetest/test_list.py b/test/jpypetest/test_list.py
@@ -45,7 +45,7 @@ def __setitem__(self, ndx, v):
                 stop = self.size() + stop
             for i in range(start, stop):
                 self.remove(start)
-            if isinstance(v, collections.Sequence):
+            if isinstance(v, collections.abc.Sequence):
                 ndx = start
                 for i in v:
                     self.add(ndx, i)