Completion of error handling

[elfring]

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• malloc ⇒ block_compile, jv_invalid_with_msg
• realloc ⇒ path_push

[stedolan]

Hrm. jq does not handle memory exhaustion gracefully. There's nothing much it can do in such a situation, so possibly the best approach would be to replace calls to malloc/realloc with calls to a wrapper that prints a message and abort()s if allocation fails.

Are there other errors that jq doesn't handle properly?

[tischwa]

1st let me say, that jq is really great!

2nd, regarding the malloc issue, I would go with the wrapper, print some message to stderr and be done with it.

I ran into this already on a 4GB machine while processing a big json file. Tracking down the SEGV finally showed, that malloc returned a NULL pointer.