Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oniguruma dependency broken #936

Closed
paulmakepeace opened this issue Sep 3, 2015 · 16 comments
Closed

oniguruma dependency broken #936

paulmakepeace opened this issue Sep 3, 2015 · 16 comments

Comments

@paulmakepeace
Copy link

An FYI for anyone else running into this,

==> Installing dependencies for jq: oniguruma
==> Installing jq dependency: oniguruma
==> Downloading http://www.geocities.jp/kosako3/oniguruma/archive/onig-5.9.6.tar.gz

curl: (22) The requested URL returned error: 403 Forbidden
Error: Failed to download resource "oniguruma"
Download failed: http://www.geocities.jp/kosako3/oniguruma/archive/onig-5.9.6.tar.gz

Which apparently translates to,

The page can not be displayed
Sorry, the accessed page is no longer currently available. Please try again later. Please check the help If you have any questions, if that does not work please contact us from within the help page.

@pkoppstein
Copy link
Contributor

@nicowilliams
Copy link
Contributor

Yeah, we're aware. We're probably going to include the tarball in the jq repo. Or perhaps we should have a jq-dependencies repo (which would require attention from @stedolan). Or perhaps we'll find a sufficiently-official (for some definition of that) successor of Oniguruma that we can use instead (it seems Onigmo would be it). We'll see.

@nicowilliams nicowilliams added this to the 1.6 release milestone Sep 3, 2015
@wtlangford
Copy link
Contributor

I'd be fine with moving to Onigmo, if there wasn't a lack of a presence in
system package managers. That's my primary concern with the switch.

On Thu, Sep 3, 2015 at 2:47 PM Nico Williams notifications@github.com
wrote:

Yeah, we're aware. We're probably going to include the tarball in the jq
repo. Or perhaps we should have a jq-dependencies repo (which would require
attention from @stedolan https://github.com/stedolan). Or perhaps we'll
find a sufficiently-official (for some definition of that) successor of
Oniguruma that we can use instead (it seems Onigmo would be it). We'll see.


Reply to this email directly or view it on GitHub
#936 (comment).

@nicowilliams
Copy link
Contributor

@wtlangford Can you look into whether it's backward compatible? Do you want to take this issue?

@wtlangford
Copy link
Contributor

Yeah, I've got some extra time this weekend so I'll pick it up

On Thu, Sep 3, 2015, 16:43 Nico Williams notifications@github.com wrote:

@wtlangford https://github.com/wtlangford Can you look into whether
it's backward compatible? Do you want to take this issue?


Reply to this email directly or view it on GitHub
#936 (comment).

@paulmakepeace
Copy link
Author

I can confirm tweaking the url in /usr/local/Library/Formula/oniguruma.rb to https://web.archive.org/web/20150803013327/http://www.geocities.jp/kosako3/oniguruma/archive/onig-5.9.6.tar.gz and re-running brew install jq worked.

Thanks all!

@elad
Copy link

elad commented Sep 4, 2015

Hi, Oniguruma just moved to GitHub, see kkos/oniguruma.

Edit: Tagged v5.9.6, available from https://github.com/kkos/oniguruma/archive/v5.9.6.tar.gz.

@nicowilliams
Copy link
Contributor

@elad: Well, there are several Onigurumas in github. Which one, if any, is canonical (for some value of canonical)?

@elad
Copy link

elad commented Sep 4, 2015

@nicowilliams the one I just pointed you at :) it's by the actual author, K. Kosako (@kkos).

I emailed him in July about moving it to GitHub so it's not just a tarball on geocities and he kindly agreed. That's why the geocities site is down (kkos/oniguruma@0b58ff7).

@nicowilliams
Copy link
Contributor

@elad Aha. It would have been nice if @kkos had left some evidence of this move in the old geocities site :( Still, we can check that the 5.9.6 tag on gh matches the 5.9.6 tarball from the web archive of the old geocities site and go from there. Thanks for the tip.

@elad
Copy link

elad commented Sep 4, 2015

If you want to verify project authenticity, the best way would be to email @kkos.

I don't know if the tag matches the old archive, I just added it myself. One of the reasons for the move to GitHub is that development history was not available before that, so I don't know at what point the archive that was on geocities was created.

@pkoppstein
Copy link
Contributor

Here is a "diff" of the "old" (onig-5.9.6) and "new" (oniguruma-master at github) repositories. The files that differ only differ insubstantially (e.g. a new email address).

$ diff -rq onig-5.9.6 oniguruma-master
Only in oniguruma-master: .gitignore
Files onig-5.9.6/AUTHORS and oniguruma-master/AUTHORS differ
Only in oniguruma-master: CMakeLists.txt
Files onig-5.9.6/COPYING and oniguruma-master/COPYING differ
Files onig-5.9.6/HISTORY and oniguruma-master/HISTORY differ
Only in onig-5.9.6: Makefile.in
Files onig-5.9.6/README and oniguruma-master/README differ
Files onig-5.9.6/README.ja and oniguruma-master/README.ja differ
Only in oniguruma-master: README.md
Only in onig-5.9.6: aclocal.m4
Only in oniguruma-master: cmake
Only in oniguruma-master: config.h.cmake.in
Only in onig-5.9.6: configure
Only in oniguruma-master: dist.info
diff: oniguruma-master/ltmain.sh: No such file or directory
Only in onig-5.9.6: m4
Files onig-5.9.6/onig-config.in and oniguruma-master/onig-config.in differ
Only in oniguruma-master: oniguruma.pc.cmake.in
Only in oniguruma-master/sample: CMakeLists.txt
Only in onig-5.9.6/sample: Makefile.in

@kmaehashi
Copy link

@kkos's blog article, which was linked from the oniguruma web site, mentions his GitHub account https://github.com/kkos/. So I believe that https://github.com/kkos/oniguruma is a genuine repository for Oniguruma.

@elad
Copy link

elad commented Sep 9, 2015

This has been fixed in Homebrew/legacy-homebrew@5eed615

@nicowilliams
Copy link
Contributor

Thanks @elad and @DomT4!

@dtolnay
Copy link
Member

dtolnay commented Oct 18, 2015

Seems like this has been resolved by #937 and Homebrew/legacy-homebrew#43699.

@dtolnay dtolnay closed this as completed Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants