use std::mem::take to avoid clone

jqnatividad · Mar 25, 2024 · 1fd187f · 1fd187f
1 parent 1fee6b7
commit 1fd187f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/cmd/apply.rs b/src/cmd/apply.rs
@@ -573,7 +573,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
             match rdr.read_record(&mut batch_record) {
                 Ok(has_data) => {
                     if has_data {
-                        batch.push(batch_record.clone());
+                        batch.push(std::mem::take(&mut batch_record));
                     } else {
                         // nothing else to add to batch
                         break;

diff --git a/src/cmd/applydp.rs b/src/cmd/applydp.rs
@@ -393,7 +393,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
             match rdr.read_record(&mut batch_record) {
                 Ok(has_data) => {
                     if has_data {
-                        batch.push(batch_record.clone());
+                        batch.push(std::mem::take(&mut batch_record));
                     } else {
                         // nothing else to add to batch
                         break;

diff --git a/src/cmd/datefmt.rs b/src/cmd/datefmt.rs
@@ -188,7 +188,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
             match rdr.read_record(&mut batch_record) {
                 Ok(has_data) => {
                     if has_data {
-                        batch.push(batch_record.clone());
+                        batch.push(std::mem::take(&mut batch_record));
                     } else {
                         // nothing else to add to batch
                         break;

diff --git a/src/cmd/geocode.rs b/src/cmd/geocode.rs
@@ -1117,7 +1117,7 @@ async fn geocode_main(args: Args) -> CliResult<()> {
             match rdr.read_record(&mut batch_record) {
                 Ok(has_data) => {
                     if has_data {
-                        batch.push(batch_record.clone());
+                        batch.push(std::mem::take(&mut batch_record));
                     } else {
                         // nothing else to add to batch
                         break;