Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch and apply: use lookup tables #231

Merged
merged 7 commits into from Apr 3, 2022
Merged

Conversation

jqnatividad
Copy link
Owner

  • to support fetch --url-template and apply dynfmt respectively
  • vec backed lookup tables for dynamic formatting of these features are faster and cheaper

also simplify iter in safe_header_names
- faster and cheaper
- also simplified censor_check and censor addl custom profanity loop
- use regex_once_cell  macro from util
- with repeating columns
rather than BTreeMap, its faster and cheaper
as integration tests run in parallel, we need to use serial_test for  `fetch` testing, as we have two tests that start a test webserver, so we want to make sure they run serially as they are listening on the same port and run async
that uses the test web server.

Note that we have the `#[serial]` hint on the tests that run a web server to ensure they do not run in parallel (as they cannot, since they listen on the same port)
- along with `serial_test`, `jql` and `zip` were bumped
@jqnatividad jqnatividad merged commit 7246c69 into master Apr 3, 2022
@jqnatividad jqnatividad deleted the dynfmt-lookup-tables branch April 12, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant