Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply: refactor #343

Merged
merged 2 commits into from
Jun 12, 2022
Merged

apply: refactor #343

merged 2 commits into from
Jun 12, 2022

Conversation

jqnatividad
Copy link
Owner

  • add --jobs option to control rayon num threads
  • increase rayon batch size to 24k from 16k
  • use enum type with match, in lieu of nested if statement - much more readable/maintainable
  • optimize progress bar init
  • removed unneeded batch_size var
  • converted match &args.flag_new_column to if args.flag_new_column.is_some()

@jqnatividad
apply: refactor
99ce5a1 
- add --jobs option to control rayon num threads
- increase rayon batch size to 24k from 16k
- use enum type with match, in lieu of nested if statement - much more readable/maintainable
- optimize progress bar init
- removed unneeded batch_size var
- converted match &args.flag_new_column to if args.flag_new_column.is_some()
@jqnatividad
apply: add EmptyReplace and Unknown enums to ApplySubCmd
550bc8b 
- move cell.is_empty check inside match arms, it was having undesired side effects which caused CI to fail
@jqnatividad jqnatividad merged commit d5a288b into master Jun 12, 2022
@jqnatividad jqnatividad deleted the apply-refactor branch June 12, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jqnatividad