Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenation Refactor for 1.17.1 minor release #143

Merged
merged 54 commits into from
Feb 2, 2020
Merged

Documenation Refactor for 1.17.1 minor release #143

merged 54 commits into from
Feb 2, 2020

Conversation

jquast
Copy link
Owner

@jquast jquast commented Feb 1, 2020

nearly complete, just some work on examples.py remain

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #143 into master will decrease coverage by 0.62%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   95.77%   95.14%   -0.63%     
==========================================
  Files           8        8              
  Lines         970      968       -2     
  Branches      154      153       -1     
==========================================
- Hits          929      921       -8     
- Misses         37       43       +6     
  Partials        4        4
Impacted Files Coverage Δ
blessed/sequences.py 100% <ø> (+1.8%) ⬆️
blessed/_capabilities.py 80% <ø> (-20%) ⬇️
blessed/win_terminal.py 27.77% <ø> (-5.56%) ⬇️
blessed/color.py 100% <100%> (ø) ⬆️
blessed/terminal.py 98.57% <100%> (-0.96%) ⬇️
blessed/keyboard.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8b2a1...fa38bb2. Read the comment docs.

@jquast
Copy link
Owner Author

jquast commented Feb 2, 2020

I'll be merging and squashing soon.. one more review

@avylove
Copy link
Collaborator

avylove commented Feb 2, 2020

Awesome! I haven't done an indepth look, but one thing I happened to notice was 'This is' should be 'This is ' at the bottom of intro.rst

@jquast jquast changed the title Documenation Refactor (DRAFT) Documenation Refactor for 1.17.1 minor release Feb 2, 2020
@jquast jquast merged commit 2dd673a into master Feb 2, 2020
@jquast jquast deleted the docs branch February 2, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants