Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases when vipAddress may not be present #102

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

mhamann
Copy link
Contributor

@mhamann mhamann commented Jan 12, 2017

Fixes #101.

@awolden
Copy link
Collaborator

awolden commented Jan 12, 2017

@mhamann Thanks for catching this. We can merge this and publish the fix immediately, but it looks like the build failed on a lint error:

/home/travis/build/jquatier/eureka-js-client/src/EurekaClient.js
  407:1  error  Trailing spaces not allowed  no-trailing-spaces
✖ 1 problem (1 error, 0 warnings)

If you can fix the trailing space and push we can merge this ASAP.

@mhamann mhamann force-pushed the patch-1 branch 2 times, most recently from 2959c27 to e45f61f Compare January 13, 2017 02:29
@mhamann
Copy link
Contributor Author

mhamann commented Jan 13, 2017

Fixed linting check and added another test for the case in question to avoid reducing code coverage.

@awolden
Copy link
Collaborator

awolden commented Jan 13, 2017

Looks good 👍

@awolden awolden merged commit 8932a47 into jquatier:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants