Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UNSAFE_componentWillReceiveProps in strict mode is not recommended #2470

Closed
wants to merge 2 commits into from

Conversation

justoverclockl
Copy link

This fix should address the warning for:

UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenev

zaosoula added a commit to ezyostudio/react-big-calendar that referenced this pull request Feb 22, 2024
jquense#2470

commit dc526d1
Merge: f2cb5e9 4e4cc15
Author: Marco Colia <79002016+justoverclockl@users.noreply.github.com>
Date:   Mon Nov 20 10:38:45 2023 +0100

    Merge pull request jquense#1 from justoverclockl/feature/fix-unsafe-warning

    Update DayColumn.js for unsafe warning

commit 4e4cc15
Author: Marco Colia <79002016+justoverclockl@users.noreply.github.com>
Date:   Mon Nov 20 10:36:23 2023 +0100

    Update DayColumn.js for unsafe warning
Copy link

@hyoloui hyoloui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@justoverclockl justoverclockl closed this by deleting the head repository Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants