Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Buttons in the controlgroup label #5352

Closed
aristotelos opened this issue Dec 6, 2012 · 4 comments
Closed

Buttons in the controlgroup label #5352

aristotelos opened this issue Dec 6, 2012 · 4 comments
Assignees
Labels
Milestone

Comments

@aristotelos
Copy link

Buttons in the controlgroup label are styled as if they are part of the controlgroup controls.

This can be fixed by two modifications to the code:
Add an extra statement after the wrapping:

    $el.wrapInner("<div class='ui-controlgroup-controls'></div>");
    groupcontrols = $el.children(".ui-controlgroup-controls");

Apply the initialize on the groupcontrols childs instead of on the $el childs:

    flipClasses(groupcontrols.find(".ui-btn" + (o.excludeInvisible ? ":visible" : "")).not('.ui-slider-handle'), flCorners);
    flipClasses(groupcontrols.find(".ui-btn-inner"), flCorners);
@jaspermdegroot
Copy link
Contributor

@aristotelos

We made a lot of changes to controlgroup. These changes are in latest code on branch master and will land in 1.3. The code you are referring to is no longer there. We don't use the JS for corner styling anymore, but do this with CSS only.

I am closing this issue. If you still see a problem with latest code, please comment and we will reopen. Thanks!

@aristotelos
Copy link
Author

See this reproduction: http://jsbin.com/onibuc/383/

@jaspermdegroot
Copy link
Contributor

@aristotelos

In this case you'll have to use a div: http://jsbin.com/onibuc/409/edit

@aristotelos
Copy link
Author

@uGoMobi Good suggestion, but I am using "fieldcontain" wrappers. See http://jsbin.com/onibuc/412/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants