Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Controlgroup: applying styling only on the content part, to avoid changes to buttons in the label. Fixed #5352 - Buttons in the controlgroup label #5821

Closed
wants to merge 2 commits into from

Conversation

aristotelos
Copy link

unknown added 2 commits March 28, 2013 15:32
…nges to buttons in the label. Fixed #5352 - Buttons in the controlgroup label
…nges to buttons in the label. Fixed #5352 - Buttons in the controlgroup label
@gseguin
Copy link
Contributor

gseguin commented Mar 28, 2013

Thank you for the pull request! I noticed that you haven't signed a CLA. Please visit http://contribute.jquery.org/CLA/ and sign it so we can look into your PR.

Thank you.

@ghost ghost assigned jaspermdegroot Apr 28, 2013
jaspermdegroot added a commit that referenced this pull request May 21, 2013
…er only. Fixes #5352. Changes from PR #5821 with some modifications. Thanks @aristotelos !
@jaspermdegroot
Copy link
Contributor

@aristotelos

Thanks for this PR! I looked into the issue again and decided that we should make the changes you suggested.
We are making a lot of big changes for 1.4 and are working on this in a branch. Because the CSS file looks completely different there I couldn't merge your PR, but had to apply the changes manually. See 963d895.

I tested this with the markup from the JS Bin that you posted at #5352. Everything looked good. You only have to unset the margin top and bottom of the button that you add to the legend.

Thanks again for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants