Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Manage client-side dependencies using Bower #6369

Closed
rxaviers opened this issue Aug 21, 2013 · 4 comments · Fixed by #6868
Closed

Manage client-side dependencies using Bower #6369

rxaviers opened this issue Aug 21, 2013 · 4 comments · Fixed by #6868
Assignees

Comments

@rxaviers
Copy link

Manage the following frontend dependencies using a tool (eg. bower). Based on whole team discussion about a consistent way of managing frontend dependencies across all projects.

dependencies:

  • jQuery Core (present on ./js);
  • jQuery UI (present on ./js);
  • jquery.hashchange (present on ./js); [1]

devDependencies:

  • requirejs (present on ./external);
  • QUnit (present on ./external);
  • jshint (to-be-included);

1: About jquery.hashchange.js modification that is not yet upstream. Can we use @gseguin modified clone in the bower config, eg. "hashchange": "gseguin/jquery-hashchange"?

@ghost ghost assigned gseguin Aug 21, 2013
@arschmitz
Copy link
Contributor

a couple things here. Qunit we want to be under dependencies along with jshint so that tests can be done without the users need to install bower or npm ( the jshint wont be until we switch to make our quint tests run it #6364 ).

As to hashchange. im not sure i have a strong opinion on this one way or the other.

@rxaviers
Copy link
Author

a couple things here. Qunit we want to be under dependencies along with jshint so that tests can be done without the users need to install bower or npm ( the jshint wont be until we switch to make our quint tests run it #6364 ).

Updated jshint on the above list. About not needing to run bower or npm after git clone, you may want to commit the dependencies after being fetched I guess.

As to hashchange. im not sure i have a strong opinion on this one way or the other.

Good, because using bower now to point to @gseguin's branch (the same one of the upstream PR) has the benefit of making the future transition (for upstream lib) smoother.

@arschmitz
Copy link
Contributor

@rxaviers yes sorry should have mentioned that yes we plan to commit the dependencies to maintain the ability to run tests and demos out of the box

@rxaviers
Copy link
Author

:)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants