Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Build: Manage dependencies with bower #6868

Merged
merged 1 commit into from
Jan 10, 2014
Merged

Build: Manage dependencies with bower #6868

merged 1 commit into from
Jan 10, 2014

Conversation

gseguin
Copy link
Contributor

@gseguin gseguin commented Dec 31, 2013

Fixes gh-6369

@gseguin
Copy link
Contributor Author

gseguin commented Dec 31, 2013

I filed timmywil/grunt-bowercopy#4 to be able to replace the @VERSION token in the jQuery UI code.

@scottgonzalez
Copy link
Contributor

I mentioned this before, but you shouldn't have @VERSION in any jQuery UI files. If you're pulling an unreleased file, you need to replace the token at commit time, not at release time.

@arschmitz
Copy link
Contributor

also you are missing jquery.ui.tabs.js

@gseguin
Copy link
Contributor Author

gseguin commented Dec 31, 2013

@scottgonzalez, not sure what you mean by "commit time" vs "release time". The bowercopy task will be used to update our dependencies after it's executed we will commit the new dependencies into the repo. At that time the @VERSION token should have been replaced already.

@gseguin
Copy link
Contributor Author

gseguin commented Dec 31, 2013

@arschmitz, good catch, adding it.

@scottgonzalez
Copy link
Contributor

@gseguin Sorry, I was confusing this was the Bower portion of the release. When this task runs that would be commit time, so what you're planning is correct. Sorry for the confusion.

@gseguin
Copy link
Contributor Author

gseguin commented Jan 8, 2014

bump!

@@ -716,6 +716,84 @@ module.exports = function( grunt ) {
}
},

bowercopy: {
options: {
// Bower components folder will be removed afterwards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line before comments

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 494d276 on bower into * on master*.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling f959f49 on bower into b989774 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) when pulling f9b441e on bower into b989774 on master.

@arschmitz
Copy link
Contributor

just make sure to squash all this and rebase then 👍

@gseguin gseguin merged commit d14b90d into master Jan 10, 2014
@gseguin gseguin deleted the bower branch January 10, 2014 17:53
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) when pulling d14b90d on bower into b989774 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage client-side dependencies using Bower
4 participants