This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Fixes #4119 - Bad URLs with hashes are not gracefully handled #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andled Fixes issue jquery-archive#4119 Added regex test to see if hash is valid and if a page with that id exists, if not load the first page.
| // if hashchange listening is disabled, there's no hash deeplink, | ||
| // the hash is not valid (contains more than one # or does not start with #) | ||
| // or there is no page with that hash, change to the first page in the DOM | ||
| if ( !$.mobile.hashListeningEnabled || /(^#$)|(#.*#.*)|(^[^#].+)/.test( location.hash ) || !$( location.hash + ':jqmData(role="page")' ).length ) { |
There was a problem hiding this comment.
I would push this into the $.mobile.path object at the top of jquery.mobile.navigation.js.
There was a problem hiding this comment.
Something like $.mobile.path.isHashValid( location.hash )?
|
In the original bug, hash listening is enabled and it's still breaking. There's something deeper to this, I think. |
|
@jlembeck With this change, if hash listening is enabled and the hash is not valid the first page will be loaded. If hash listening is disabled then the first page will be loaded. |
Added unit tests for isHashValid
|
@jasondscott gotcha. Read my results incorrectly when trying it out on my URL. |
jasondscott
added a commit
that referenced
this pull request
May 26, 2012
Fixes #4119 - Bad URLs with hashes are not gracefully handled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4119
Added regex test to see if hash is valid and if a page with that id
exists, if not load the first page.