Added Danish(DK) Phone number

[BenjaminHoegh]

Matches DK phone number format

allows '-' or ' ' as a separator and allows parens around area code
some people may want to put a '+45' in front of their number

• +45 21-77-21-77
• +45 21 77 21 77
• +45 21772177
• +4521772177
• 21 77 21 77
• 21-77-21-77
• 2177 2177
• 2177-2177
• 21772177

but not

• +1 3243121212
• +45 112
• +452143284233
• 2143284233

[staabm]

Please add tests

[BenjaminHoegh]

@staabm what do you mean ??? screenshots?

[staabm]

I mean unit tests, see the tests folder. I also realized we dont have tests for the other languages, so this is not a must have.

@Arkni could you add some example tests for phoneUs so people see a example?

[Arkni]

Thanks for the PR. 2 small changes and we are good to land.

[Arkni]

Please use regex.test(string) instead of string.match(regex). We only need to know whether the phone number matches the regex or not. We don't need to retrieve the matched parts.

Also, please use non-capturing instead of capturing groups [1]

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp#grouping-back-references

[BenjaminHoegh]

okay thanks, will look on it later this week

[staabm]

@Arkni can this regex codestyle be enforced via jshint?

[Arkni]

None that I am aware of.

[Arkni]

@staabm
I will see if I can find a moment to work on them tomorrow.

Tests should not block us from merging this PR though, as @HawkonDK can add them in another PR.

[Arkni]

@staabm
Just did a quick read to the test files and I found that tests for phoneUS are already added (phoneUK tests are there too). See

jquery-validation/test/methods.js

Lines 779 to 789 in 38cb9b9

	QUnit.test( "phone (us)", function( assert ) {
	var method = methodTest( "phoneUS" );
	assert.ok( method( "1(212)-999-2345" ), "Valid US phone number" );
	assert.ok( method( "212 999 2344" ), "Valid US phone number" );
	assert.ok( method( "212-999-0983" ), "Valid US phone number" );
	assert.ok( !method( "111-123-5434" ), "Invalid US phone number. Area Code cannot start with 1" );
	assert.ok( !method( "212 123 4567" ), "Invalid US phone number. NXX cannot start with 1" );
	assert.ok( !method( "234-911-5678" ), "Invalid US phone number, because the exchange code cannot be in the form N11" );
	assert.ok( !method( "911-333-5678" ), "Invalid US phone number, because the area code cannot be in the form N11" );
	assert.ok( method( "234-912-5678" ), "Valid US phone number" );
	} );

[staabm]

@Arkni awesome, we should separate them into a „additional“ folder and equal named files like the impl then

[Arkni]

Hi @HawkonDK
Are you willing to continue working on this?

Thanks!