Danish Update #2165
Closed
Danish Update #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Danish translation for phone numbers and postal code
|
Have no idea about why its keep failing the test |
|
Thanks for your contribution! and sorry for taking so long to repond to this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has somehow made me lose the permissions to edit #2070 #2071 and #2072. So here is a new pull-request with the changes and all-in-one request (my old pc couldn't run GitHub sorry for that).
Phone
Accepts:
+45 21-77-21-77
+45 21 77 21 77
+45 21772177
+4521772177
21 77 21 77
21-77-21-77
2177 2177
2177-2177
21772177
Have changed the regex to use the non-capturing group as requested.
Postal codes
Have also changed the postal codes to accept from the Danish Kingdom instead of Danish and Greenland only. This means that the Faroe Islands is now included.