Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered require_from_group so checkboxes and radiobuttons #359

Closed
wants to merge 1 commit into from

Conversation

pderaaij
Copy link

@pderaaij pderaaij commented Apr 5, 2012

Altered require_from_group so checkboxes and radiobuttons are taken in to account.

@mlynch
Copy link
Contributor

mlynch commented Apr 5, 2012

Could you update the test cases for require_from_group to verify this change works? Thanks, it seems like a necessary fix.

@pderaaij
Copy link
Author

pderaaij commented Apr 6, 2012

I'm away for the weekend, but will change it later this week. Thanks for the remarks.

@mlynch
Copy link
Contributor

mlynch commented Apr 17, 2012

Hi, I think this will be fixed by #368. We need to change the val() call in this function to use elementValue, which will help maintain consistency anyways. I'm going to submit a separate fix for this. Thanks!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants