Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Clarify the circumstances of and data associated with pagebeforechange #356

Closed
wants to merge 2 commits into from
Closed

Navigation: Clarify the circumstances of and data associated with pagebeforechange #356

wants to merge 2 commits into from

Conversation

gabrielschulhof
Copy link

Fixes gh-355

@gabrielschulhof gabrielschulhof added this to the 1.5 milestone Jan 29, 2015
@gabrielschulhof
Copy link
Author

@agcolom I've removed the "already".

@agcolom
Copy link
Member

agcolom commented Feb 3, 2015

@gabrielschulhof Thank you. LGTM

@arthurvr
Copy link
Member

Is this PR ready to get merged?

@arschmitz
Copy link
Member

👍

gabrielschulhof pushed a commit that referenced this pull request Feb 12, 2015
Navigation: Clarify the circumstances of and data associated with pag…
f5d98b3 
…ebeforechange

(cherry picked from commit 453be66)

Fixes gh-355
Closes gh-356
@gabrielschulhof gabrielschulhof deleted the 355-clarify-pagebeforechange branch February 12, 2015 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arschmitz arschmitz

Labels
OK to land
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Pagecontainer: Clarify value of data.toPage during pagebeforechange
4 participants
@gabrielschulhof @agcolom @arthurvr @arschmitz