Template Strings: fix double scanning of template literals #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also breaks scanning of { and } into a separate clause in the switch statement
to avoid having to conditional logic related to the stack on unrelated tokens.
This more closely reflects the situation in the master branch as well.
Fixes jquery#1143
Closes jquerygh-1145
mikesherov
force-pushed
the
templateFix2
branch
from
0c0195e
to
edebcb7
Compare
|
This seems like it makes sense and it fixes all the cases we had that were failing so 👍. I am probably the worst person to actually review the code. I can find bugs and merge our fork (sometimes) but I still don't know how esprima actually works. |
|
The changes look good to me. Very clean. :) |
|
👍 looks good. Sounds like @zpao has run it across our codebase with no problems too, which I've found to be a pretty reassuring smoke test |
|
OK, landing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also breaks scanning of { and } into a separate clause in the switch statement
to avoid having to conditional logic related to the stack on unrelated tokens.
This more closely reflects the situation in the master branch as well.
Fixes #1143