Redirects: Add support for setting redirects in redirects.json #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| client = wp.createClient( config ); | ||
|
|
||
| client.authenticatedCall( "jq.setRedirects", JSON.stringify( redirects ), this.async() ); | ||
| }); |
| var wp = require( "wordpress" ); | ||
|
|
||
| grunt.registerTask( "redirects", function() { | ||
| var config = grunt.config( "wordpress" ), |
There was a problem hiding this comment.
We don't really do onevar anymore (jquery/contribute.jquery.org#105)
gnarf
force-pushed
the
redirects
branch
3 times, most recently
from
5c619e2
to
16714f3
Compare
| var redirects = grunt.file.exists( "redirects.json" ) ? grunt.file.readJSON( "redirects.json" ) : {}; | ||
| var client = wp.createClient( config ); | ||
|
|
||
| client.authenticatedCall( "jq.setRedirects", JSON.stringify( redirects ), this.async() ); |
There was a problem hiding this comment.
Under the hood grunt.file.readJSON just reads a file and JSON.parse's it, so it seemed kinda strange that we're directly JSON.stringifying it again.
There was a problem hiding this comment.
Or is this just because we can catch syntax errors in the file more easily this way?
There was a problem hiding this comment.
Exactly, I wanted grunt to error on invalid JSON.
|
Looks alright, along with jquery/jquery-wp-content#368 |
jzaefferer
added a commit
to qunitjs/qunitjs.com
that referenced
this pull request
Jul 21, 2015
|
I've tested with qunitjs.com, works fine: qunitjs/qunitjs.com#103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would allow us to add a
redirects.jsonin the following format:{ "/addons/": "/plugins/" }Closes #61